Preliminary cleanups for creating fewer GenericSignatureBuilders #19580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Canonicalizing GenericFunctionTypes is a very expensive operation, and we assert elsewhere that they do not contain archetypes.
…ureBuilder::inferRequirements()
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
Build failed |
|
Build failed |
This was mechanically converted from the old function type representation, but the 'single tuple argument' case is bogus.
Most of the time we don't need it, and accessing a generic environment on a deserialized declaration creates a GenericSignatureBuilder.
…berNamesTableInfo Named lazy member loading skips constructors right now anyway for other reasons, but trying to re-enable it hits this problem first.
slavapestov
force-pushed
the
fewer-gsb-part-1
branch
from
a05c3de to
87a49ff
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
@DougGregor Mind taking a look? This is just a grab-bag of random unrelated changes at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on some experimental changes which reduce the number of GenericSignatureBuilders that get created. This PR has a bunch of smaller changes that fell out of this work.