[stdlib] Mark reversed as consuming

[airspeedswift]

Since either the elements go into an array, or the collection is wrapped, it's likely this would be the better choice. We'll see if the benchmarks agree (needs #19613 for any change to show up).

[airspeedswift]

cc @jckarter

[airspeedswift]

@swift-ci please smoke test

[airspeedswift]

@swift-ci please benchmark

[swift-ci]

Build comment file:

No performance and code size changes

How to read the data

The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false alarms. Unexpected regressions which are marked with '(?)' are probably noise. If you see regressions which you cannot explain you can try to run the benchmarks again. If regressions still show up, please consult with the performance team (@eeckstein).

Hardware Overview

  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

---

[airspeedswift]

What no changes, not even noise? 🤔

[jrose-apple]

I'd guess this gets inlined 100% of the time.

EDIT: Okay, that still wouldn't explain -Onone.

[airspeedswift]

@swift-ci please smoke benchmark

[swift-ci]

Build comment file:

Performance: -O

TEST	OLD	NEW	DELTA	RATIO
Improvement
CStringLongAscii	3539	3300	-6.8%	1.07x

Performance: -Osize

TEST	OLD	NEW	DELTA	RATIO
Improvement
CStringLongAscii	3537	3288	-7.0%	1.08x

Performance: -Onone

TEST	OLD	NEW	DELTA	RATIO
Regression
ArrayOfPOD	781	860	+10.1%	0.91x (?)

How to read the data

The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false alarms. Unexpected regressions which are marked with '(?)' are probably noise. If you see regressions which you cannot explain you can try to run the benchmarks again. If regressions still show up, please consult with the performance team (@eeckstein).

Hardware Overview

  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

---