SR-8925: Require clang-3.9 on Ubuntu 14.04 #19735
Conversation
Since commit 3469797 changed to build libdispatch for SourceKit with the host compiler, we now require a clang with builtin `__builtin_add_overflow`. Since Ubuntu 14 repositories have a clang that supports this update our build instructions to use it. Resolves [SR-8925](https://bugs.swift.org/browse/SR-8925).
|
cc @jrose-apple |
|
Seems reasonable, but possibly something we should have discussed first. cc @najacque, @shahmishal |
|
@jrose-apple @compnerd I'm signing off for the weekend but if this is something that needs discussion then we should probably revert 3469797 to un-break the Ubuntu14 build. |
|
@jrose-apple, I agree with it being nice to announce the minimum versions being updated early, however, 3.9 is over 2 years old at this point. 3.4 is pretty ancient (4+ years old!). I suppose that we can switch the libdispatch build back to using the just built compiler if this isn't something we can accommodate. |
|
@jrose-apple it looks like CI bots are now using Clang 7.0.0. Are you happy for me to merge this change? |
|
It's a policy question more than a practical question, and someone other than me should decide that project. Maybe it's worth bringing up on the forums? |
|
@kevints Did you ever wind up taking this to evolution? |
|
I suppose it doesn't matter now that we don't support 14.04. Going to merge at least so anybody trying to build on a legacy target doesn't run into the same bugs, |
|
@swift-ci please smoke test and merge |
Since commit 3469797 changed to build libdispatch for SourceKit with the
host compiler, we now require a clang with builtin
__builtin_add_overflow.Since Ubuntu 14 repositories have a clang that supports this update our
build instructions to use it.
Resolves SR-8925.