[ConstraintSystem] Tweak -disable-constraint-solver-performance-hacks. #19749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow a couple of the tests in shortCircuitDisjunctionAt() to run even when hacks are disabled. The first of these tests is imperfect since it assumes that "favored" disjunction choices all come before the others (which may be the case now but is pretty brittle). Similarly, the second of these tests assumes that choices that are fixes always come after ones that are not. What we really want to do is skip these choices rather than stopping at these points.
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow a couple of the tests in shortCircuitDisjunctionAt() to run even
when hacks are disabled.
The first of these tests is imperfect since it assumes that "favored"
disjunction choices all come before the others (which may be the case
now but is pretty brittle).
Similarly, the second of these tests assumes that choices that are
fixes always come after ones that are not.
What we really want to do is skip these choices rather than stopping
at these points.