-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[sourcekit] Fix for Ubuntu 16.04 Swift ASAN bot sourcekitd-test failures #20055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sourcekit] Fix for Ubuntu 16.04 Swift ASAN bot sourcekitd-test failures #20055
Conversation
@swift-ci please test |
7ce621d
to
3fe0ab8
Compare
@swift-ci please test |
Build failed |
Build failed |
Don't mix and match between the just-built clang and the host clang when ASAN is enabled. rdar://problem/45273748
3fe0ab8
to
15dd6f9
Compare
@compnerd I got back to this and managed to reproduce the failure locally with an Ubuntu 16.04 docker image and you were right, the check was the wrong way around. The changes as they stand now fixed the ASAN mismatch in Was there a specific requirement for 3.9+ building libdispatch here or was this just a known good configuration? It seems to build fine when I drop it to > 3.7 locally (my Ubuntu 16.04 docker setup has 3.8). |
@swift-ci please test |
Build failed |
@swift-ci smoke test osx |
@swift-ci please smoke test |
@nathawes We are going kill Linux build to investigate lldb test issue. |
@swift-ci Please smoke test OS X platform |
@swift-ci Please smoke test Linux platform |
https://ci.swift.org/job/oss-swift-incremental-ASAN-RA-ubuntu-16_04/
All the
sourcekitd-test
invocations are failing due to:sourcekitd-test: symbol lookup error: /home/buildnode/jenkins/workspace/oss-swift-incremental-ASAN-RA-ubuntu-16_04/buildbot_incremental_asan/swift-linux-x86_64/tools/SourceKit/libdispatch-prefix/lib/libBlocksRuntime.so: undefined symbol: __asan_version_mismatch_check_v8
The change here forces using the host compiler if sanitizers are enabled.
Resolves rdar://problem/45273748