Skip to content

Conversation

nathawes
Copy link
Contributor

@nathawes nathawes commented Oct 25, 2018

https://ci.swift.org/job/oss-swift-incremental-ASAN-RA-ubuntu-16_04/

All the sourcekitd-test invocations are failing due to:
sourcekitd-test: symbol lookup error: /home/buildnode/jenkins/workspace/oss-swift-incremental-ASAN-RA-ubuntu-16_04/buildbot_incremental_asan/swift-linux-x86_64/tools/SourceKit/libdispatch-prefix/lib/libBlocksRuntime.so: undefined symbol: __asan_version_mismatch_check_v8

The change here forces using the host compiler if sanitizers are enabled.

Resolves rdar://problem/45273748

@nathawes
Copy link
Contributor Author

@swift-ci please test

@nathawes nathawes force-pushed the r45273748-speculative-fix-for-asan-bot-sourcekit-failures branch from 7ce621d to 3fe0ab8 Compare October 25, 2018 22:59
@nathawes
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 7ce621d93f9e59013083ddfc3fda22cbb95f8704

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 7ce621d93f9e59013083ddfc3fda22cbb95f8704

Don't mix and match between the just-built clang and the host clang when
ASAN is enabled.

rdar://problem/45273748
@nathawes nathawes force-pushed the r45273748-speculative-fix-for-asan-bot-sourcekit-failures branch from 3fe0ab8 to 15dd6f9 Compare November 8, 2018 17:58
@nathawes nathawes changed the title [sourcekit] Speculative fix for Ubuntu 16.04 Swift ASAN bot sourcekitd-test failures [sourcekit] Fix for Ubuntu 16.04 Swift ASAN bot sourcekitd-test failures Nov 8, 2018
@nathawes
Copy link
Contributor Author

nathawes commented Nov 8, 2018

@compnerd I got back to this and managed to reproduce the failure locally with an Ubuntu 16.04 docker image and you were right, the check was the wrong way around. The changes as they stand now fixed the ASAN mismatch in sourcekitd-test locally for me, but I was wondering if we could lower the required version here generally instead of forcing it to use the host compiler when ASAN is enabled.

Was there a specific requirement for 3.9+ building libdispatch here or was this just a known good configuration? It seems to build fine when I drop it to > 3.7 locally (my Ubuntu 16.04 docker setup has 3.8).

@nathawes nathawes requested a review from compnerd November 8, 2018 18:53
@nathawes
Copy link
Contributor Author

nathawes commented Nov 8, 2018

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Nov 8, 2018

Build failed
Swift Test OS X Platform
Git Sha - 3fe0ab8f0711ad2fe2ce3429f76f4b80bdc563a7

@nathawes
Copy link
Contributor Author

nathawes commented Nov 8, 2018

@swift-ci smoke test osx

@nathawes
Copy link
Contributor Author

nathawes commented Nov 8, 2018

@swift-ci please smoke test

@shahmishal
Copy link
Member

@nathawes We are going kill Linux build to investigate lldb test issue.

@nathawes
Copy link
Contributor Author

nathawes commented Nov 9, 2018

@swift-ci Please smoke test OS X platform

@nathawes
Copy link
Contributor Author

nathawes commented Nov 9, 2018

@swift-ci Please smoke test Linux platform

@nathawes nathawes merged commit 2964b58 into swiftlang:master Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants