Add more type checker performance tests. #20057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also move one from fast to slow based on the fact that it wasn't representative of the original issue (which was an expression that didn't typecheck successfully).
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test OS X platform |
xedin
approved these changes
Oct 26, 2018
| @@ -310,8 +310,8 @@ CharacterTests.test( | |||
| expectEqualMethodsForDomain( | |||
| ascii0to126, | |||
| ascii1to127, | |||
| { x in { String(x) < String($0) } } as PredicateFn, | |||
| { x in { String(Character(x)) < String(Character($0)) } } as PredicateFn) | |||
There was a problem hiding this comment.
Nit: if PredicateFn is no longer useful, typealias could be removed as well..
There was a problem hiding this comment.
D'oh! Yes, will push another commit to remove that.
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also move one from fast to slow based on the fact that it wasn't
representative of the original issue (which was an expression that
didn't typecheck successfully).