[sil] Give the methods for querying ownership on SILFunction clearer … #20062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@atrick a gift for you. I am doing the [ossa] thing to get rid of -assume-parsing-unqualified-ownership-sil. |
|
Actually, I am going to do both of these two things together. |
|
😃 |
Done using Xcode's refactoring engine.
|
Changed my mind, going to just change this singularly in this PR. I am going to do [ossa] in another PR. |
gottesmm
force-pushed
the
pr-8d1e1d25d9d909af8231dfb8cfe502e0fef3043d
branch
from
6296136 to
23378cc
Compare
|
@swift-ci smoke test and merge |
3 similar comments
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…names.
These functions were created in the very beginning of bringing up ownership in
SIL. The concepts have evolved over time slightly so we can now give these
better names. The renames are specifically:
This is a pure rename, so I did not do any reformatting/etc.