[PrintAsObjC] Disable -Watimport-in-framework-header warning in generated headers #20086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Important when we’re testing features which are only in the new clang.
Silences a new warning in clang.
jrose-apple
reviewed
Oct 26, 2018
The atimport-in-framework-header warning is only actually emitted if the header’s path looks like it’s in a framework. We don’t have a test like that, but mixed-framework.swift probably *ought* to be like that, so if we make it more realistic, it will suit our purposes.
jrose-apple
reviewed
Oct 30, 2018
|
@swift-ci please smoke test |
|
@jrose-apple Okay with merging this? |
|
Ah, yeah, sorry, those were my only remaining comments. |
jrose-apple
approved these changes
Oct 31, 2018
|
Thanks for taking this! |
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test linux platform |
1 similar comment
|
@swift-ci please smoke test linux platform |
|
XCTest failure of an async test, so there's every reason to believe it's spurious. |
|
@swift-ci please smoke test linux platform |
milseman
pushed a commit
to milseman/swift
that referenced
this pull request
Nov 4, 2018
…ated headers (swiftlang#20086) This is a new warning in clang when you use @import in a framework header. That’s often a mistake, but it isn’t in our generated -Swift.h headers. If we’re building with a clang that supports this warning, we’ll now emit a pragma to disable it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new warning in clang when you use @import in a framework header. That’s often a mistake, but it isn’t in our generated
-Swift.hheaders. If we’re building with a clang that supports this warning, we’ll now emit a pragma to disable it.Fixes rdar://41552597.