Runtime: Unconditionally realize superclass metadata in swift_updateClassMetadata() [5.0] #20095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lassMetadata() Previously we were only doing this in assert builds, or if the new Objective-C runtime metadata update hook mechanism was available. However, swift_checkMetadataState() gets called on the superclass of a class, and it assumes that the metadata entry for the superclass already exists in the singleton cache. So even on an older runtime when there's no initialization work to be done, we have to realize the superclass to populate the singleton cache so that the check can succeed. Fixes <rdar://problem/45569020>.
|
@swift-ci Please test macOS |
slavapestov
changed the title
|
Build failed |
|
@swift-ci Please test macOS |
|
Build failed |
|
@swift-ci Please test macOS |
|
Build failed |
|
@swift-ci Please test macOS |
|
Build failed |
|
@swift-ci Please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were only doing this in assert builds, or if the
new Objective-C runtime metadata update hook mechanism was
available.
However, swift_checkMetadataState() gets called on the superclass
of a class, and it assumes that the metadata entry for the
superclass already exists in the singleton cache.
So even on an older runtime when there's no initialization work
to be done, we have to realize the superclass to populate the
singleton cache so that the check can succeed.
Fixes rdar://problem/45569020.