Carefully split the build's invocation of add_swift_library into host… #20108
+811
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
compnerd
approved these changes
Oct 27, 2018
|
@compnerd yes. It was a copy/paste. I didn't touch anything. |
|
Actually, I am going to add additionally checks in both to make sure we are passing things down the right path. |
…/target variants. The key thing here is that all of the underlying code is exactly the same. I purposely did not debride anything. This is to ensure that I am not touching too much and increasing the probability of weird errors from occurring. Thus the exact same code should be executed... just the routing changed.
gottesmm
force-pushed
the
pr-20eec6aebde959054cd379fa1a799cd8fbeaec61
branch
from
18acb33 to
3f17bb6
Compare
|
@swift-ci test |
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
|
@swift-ci test |
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
|
Build failed |
|
Linux builds failed b/c swift-5.0-branch on apple/swift-clang hadn't been merged yet into stable I think. We are using the newly built clang to compile Foundation, so this should have worked. Lets take this out for another spin. |
|
@swift-ci test linux platform |
|
@swift-ci smoke test linux platform |
1 similar comment
|
@swift-ci smoke test linux platform |
|
Its done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…/target variants.
The key thing here is that all of the underlying code is exactly the same. I
purposely did not debride anything. This is to ensure that I am not touching too
much and increasing the probability of weird errors from occurring. Thus the
exact same code should be executed... just the routing changed.