[Frontend] Remove -enable-operator-designated-types #20203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
harlanhaskins
force-pushed
the
operator-oh-would-you-help-me-place-this-call
branch
from
6bb60d3 to
88861ff
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS platform |
harlanhaskins
force-pushed
the
operator-oh-would-you-help-me-place-this-call
branch
from
88861ff to
73203fe
Compare
|
@swift-ci please smoke test |
jrose-apple
approved these changes
Nov 1, 2018
|
@swift-ci please smoke test |
|
Another option here would be to remove the use of the staging option in building the stdlib, and also set |
|
@rudkx I think that's the better way to go. |
harlanhaskins
force-pushed
the
operator-oh-would-you-help-me-place-this-call
branch
2 times, most recently
from
0949268 to
53e1b98
Compare
harlanhaskins
changed the title
|
@swift-ci please test |
|
Build failed |
|
Build failed |
graydon
approved these changes
Nov 8, 2018
rudkx
reviewed
Nov 8, 2018
harlanhaskins
force-pushed
the
operator-oh-would-you-help-me-place-this-call
branch
2 times, most recently
from
fc856d8 to
05126ec
Compare
Because this feature mostly exists for the standard library, turn it on specifically. This avoids having to serialize it in the flags necessary for parseable interfaces.
harlanhaskins
force-pushed
the
operator-oh-would-you-help-me-place-this-call
branch
from
05126ec to
44f1806
Compare
rudkx
approved these changes
Nov 10, 2018
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds -enable-operator-designated-types to the set of flags
serialized at the top of a .swiftinterface file, as it's used in the
standard library.
We need a better, long-term solution to staging flags like this one, but
this helps get the standard library building lazily from an interface.