Assert that tap vars are in the current DeclContext #20303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
Build failed |
|
Flaky Linux test strikes again. |
|
@swift-ci please test linux platform |
|
Build failed |
This assertion would have caught the last-minute bug in the string interpolation rework.
beccadax
force-pushed
the
asserting-my-correctness
branch
from
efd164f to
f0267ad
Compare
|
@swift-ci please test source compatibility |
|
@swift-ci please smoke test |
beccadax
changed the title
|
@swift-ci please test source compatibility |
|
The Tagged source compatibility failure is known to be caused by something else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This assertion would have caught the last-minute bug in the string interpolation rework, but I'm not sure it actually holds in all cases—I've already found one exception (single-expression closures) and there may be others.
I'm running it against more code to see if there are other special cases I need to account for, or if this is not a general rule I can rely on.