Revert "Revert "Revert "[Build System: CMake] make add_swift_library … #20362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a wrapper to add_llvm_library""" This reverts commit 121f5b6. Sorry to revert this again. This commit makes some pretty big changes. After messing with the merge-conflict created by this internally, I did not feel comfortable landing this now. I talked with Saleem and he agreed with me that this was the right thing to do.
|
@swift-ci smoke test and merge |
|
the xctest failure = /. |
|
@swift-ci smoke test linux platform |
|
Thanks @milseman! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…a wrapper to add_llvm_library"""
This reverts commit 121f5b6.
Sorry to revert this again. This commit makes some pretty big changes. After
messing with the merge-conflict created by this internally, I did not feel
comfortable landing this now. I talked with Saleem and he agreed with me that
this was the right thing to do.