Skip to content

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Nov 6, 2018

Swift uses LinkOnceODR with Internal linkage and normal Internal linkage quite
frequently. Define a constant for this.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd
Copy link
Member Author

compnerd commented Nov 7, 2018

@swift-ci please test and merge

@compnerd compnerd force-pushed the odr branch 2 times, most recently from 3bc0e7d to 4d3b418 Compare November 7, 2018 02:38
@compnerd
Copy link
Member Author

compnerd commented Nov 7, 2018

@swift-ci please test and merge

@compnerd
Copy link
Member Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - ef1897dcd2b945b883e0728fc660e64dd71b5ac2

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - ef1897dcd2b945b883e0728fc660e64dd71b5ac2

@compnerd
Copy link
Member Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - ef1897dcd2b945b883e0728fc660e64dd71b5ac2

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - ef1897dcd2b945b883e0728fc660e64dd71b5ac2

Swift uses LinkOnceODR with Internal linkage and normal Internal linkage quite
frequently.  Define a constant for this.
@compnerd
Copy link
Member Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 7fd0ffe687b59889cdf2880dfb756cadbedeb12d

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 7fd0ffe687b59889cdf2880dfb756cadbedeb12d

@compnerd compnerd merged commit 4d4b7ec into swiftlang:master Nov 14, 2018
@compnerd compnerd deleted the odr branch November 14, 2018 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants