[test] Add an xfail test demonstrating SR-1129 #2039
Conversation
|
This probably belongs in a different |
modocache
changed the title
|
@gribozavr Friendly ping! It'd be nice to point to a failing test case for https://bugs.swift.org/browse/SR-1129. Advice on where this test belongs would be appreciated, though. |
| @@ -0,0 +1,3 @@ | |||
| public class BaseClass { | |||
| public internal(set) var variable: Int = 0 | |||
|
@modocache It is unclear now where should this test go. The test would be placed into a directory that corresponds to the component where the bug is, and it would be FileCheck'ing the IR instead of building a whole binary. If you do want to build a whole binary (just because we don't know anything more specific about the bug now), I'd suggest moving the test to
Doesn't the obvious workaround work? Try creating a backing |
Assuming I'm understanding you correctly, I don't think that works. For example, this doesn't work if we change the I'll move the test to |
|
@modocache do you still plan on moving the test case? |
SR-1129 tracks an issue in which the linking step fails if a base class, defined in an imported module with a `public private(set) var`, is subclassed by another module. This adds a test that XFAILs on Linux. The test passed on OS X. This issue is currently forcing swift-corelibs-xctest and swift-corelibs-foundation to mark several privately-used variables as `public`.
modocache
force-pushed
the
sr-1129-xfail
branch
from
c5b0850 to
ef1be86
Compare
|
@tkremenek Done! Sorry for the wait :) |
|
Assigned back to you for a "@swift-ci please test and merge" 🙇 |
|
@swift-ci Please test and merge |
What's in this pull request?
SR-1129 tracks an issue in which the linking step fails if a base class, defined in an imported module with a
public private(set) var, is subclassed by another module. This adds a test that XFAILs on Linux. The test passed on OS X.This issue is currently forcing swift-corelibs-xctest and swift-corelibs-foundation to mark several privately-used variables as
public.ResolvedRelated bug number: (SR-1129)Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.