Skip to content

[stdlib] Make _Unwrappable internal and rename func unwrap() to _unwrap() #20511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2018
Merged

[stdlib] Make _Unwrappable internal and rename func unwrap() to _unwrap() #20511

merged 1 commit into from
Nov 12, 2018

Conversation

lorentey
Copy link
Member

_Unwrappable isn’t used in inlinable context.

This was uncovered by @jrose-apple's improved diagnostics in #20485.

@lorentey
[stdlib] Make _Unwrappable internal and rename func unwrap() to _unwr…
08c8137 
…ap()

_Unwrappable isn’t used in inlinable context.
@lorentey
Copy link
Member Author

@swift-ci please test

@lorentey lorentey mentioned this pull request Nov 12, 2018
Closed
@millenomi
Copy link
Contributor

millenomi commented Nov 12, 2018 •
edited
Loading

Ah, good call. It was called from an inlinable context at some point during patch development, but we don't need inlinability there.

@lorentey lorentey merged commit 41e9dab into swiftlang:master Nov 12, 2018
@lorentey lorentey deleted the ununwrappable branch November 12, 2018 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrose-apple jrose-apple Awaiting requested review from jrose-apple

1 more reviewer

@millenomi millenomi millenomi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lorentey @millenomi