[Driver] Don't suggest using the "major version" for -swift-version #20563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@davidungar Review ping! |
This was a nice feature when people said "-swift-version 3.1"... up until we got "-swift-version 4.2" as an actual valid version. Just drop the special case. https://bugs.swift.org/browse/SR-8850
jrose-apple
force-pushed
the
major-misstep
branch
from
6b92086 to
fb338f2
Compare
|
@swift-ci Please smoke test |
|
Thanks for the ping—will get on it this morning. In future, feel free to ping me immediately! Don’t know why I miss these.
… On Dec 7, 2018, at 9:05 AM, Jordan Rose ***@***.***> wrote:
@davidungar <https://github.com/davidungar> Review ping!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#20563 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAcJ0LCFzjD3kejYt5SPFbsHFhLqDzArks5u2p_EgaJpZM4Yc7x2>.
|
|
Hmph, test failure is from merges not syncing up across repos. |
davidungar
approved these changes
Dec 7, 2018
|
@swift-ci Please smoke test Linux |
|
@swift-ci Please smoke test macOS |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Dec 10, 2018
…wiftlang#20563) This was a nice feature when people said "-swift-version 3.1"... up until we got "-swift-version 4.2" as an actual valid version. Just drop the special case. https://bugs.swift.org/browse/SR-8850 (cherry picked from commit 00ed3e1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a nice feature when people said "-swift-version 3.1"...up until we got "-swift-version 4.2" as an actual valid version. Just drop the special case.
SR-8850 / rdar://problem/44797691