[Runtime] Fix leak when casting to AnyHashable. #20836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_dynamicCastToAnyHashable assumed that _swift_convertToAnyHashableIndirect takes its argument at +1, but that is no longer the case. rdar://problem/44686587
|
@swift-ci please test |
gottesmm
reviewed
Nov 28, 2018
| do { | ||
| let tracked = LifetimeTracked(42) | ||
| let anyHashable = AnyHashable(tracked) | ||
| let anyObject = anyHashable as AnyObject |
There was a problem hiding this comment.
This is testing two different cases. Aren't there 3 types of cast consumption? I think you will need a full on address only type to test that, no? Maybe my memory is wrong.
|
Build failed |
rjmccall
reviewed
Nov 29, 2018
| sourceType->deallocateBufferIn(&buffer); | ||
| // Destroy the value if requested. | ||
| if (flags & DynamicCastFlags::TakeOnSuccess) { | ||
| sourceType->vw_destroy(source); |
There was a problem hiding this comment.
The other way of doing this, by the way, would be to mark the intrinsic parameter as __owned. I don't have an opinion about whether TakeOnSuccess or !TakeOnSuccess is more important to optimize.
rjmccall
approved these changes
Nov 29, 2018
The call to swift_unboxFromSwiftValueWithType needs to destroy the value on success when requested in the flags. rdar://problem/44686587
|
@swift-ci please test |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_dynamicCastToAnyHashableassumed that_swift_convertToAnyHashableIndirecttakes its argument at +1, but that is no longer the case.rdar://problem/44686587