[5.0] [ABI] Make swift::swift_conformsToSwiftProtocol overridable #21028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tProtocol. We know we're going to want this parameter to handle lookup of retroactive conformances when we've been given a module, so add it now because we want this to be an overridable entry point. (cherry picked from commit f9797b4)
This is a funnel point for looking up the protocol conformance descriptor for a given conforming type + conformance. Make it overridable in case we need to back-deploy changes or fixes. Implements rdar://problem/46281660. (cherry picked from commit da772e9)
|
@swift-ci please test |
AnnaZaks
approved these changes
Dec 5, 2018
DougGregor
deleted the
runtime-override-conforms-to-swift-protocol-5.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ABI Addition: Make the funnel point for looking up the protocol conformance
descriptor for a given conforming type + conformance overridable. It's an
internal entry point, so there are no clients of it outside of the runtime, making
this strictly ABI-additive (doesn't break existing binaries). It's an important
hook for backward-deployment, however.
This is a funnel point for looking up the protocol conformance descriptor
for a given conforming type + conformance. Make it overridable in case we
need to back-deploy changes or fixes.
Implements rdar://problem/46281660.