[Runtime] Allow casts from AnyHashable to a Hashable enum to succeed. #21044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Build failed |
mikeash
force-pushed
the
anyhashable-to-enum-fix
branch
from
cb350ca to
2fad867
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
rjmccall
approved these changes
Dec 5, 2018
stdlib/public/runtime/Casting.cpp
Outdated
| @@ -2437,6 +2437,15 @@ static bool swift_dynamicCastImpl(OpaqueValue *dest, OpaqueValue *src, | |||
| cast<StructMetadata>(targetType), | |||
| flags); | |||
| } | |||
|
|
|||
| // AnyHashable casts for enums. | |||
| if (targetType->getKind() == MetadataKind::Enum) { | |||
There was a problem hiding this comment.
Thanks. I was trying to be explicit but it ended up a bit awkward. The comment alone is sufficient.
rdar://problem/46472361
mikeash
force-pushed
the
anyhashable-to-enum-fix
branch
from
2fad867 to
6f7143b
Compare
|
@swift-ci please smoke test and merge |
1 similar comment
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://problem/46472361