[ParseableInterface] Pass down the module name and import source loc #21094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use the name for the cached module, so that we don't end up with a zillion "x86_64-XXXXXXXX.swiftmodule" files in the cache when we're working with architecture-specific swiftmodules. - Diagnose if the expected name is different from the name specified in the swiftinterface. - Emit all diagnostics at the location of the import, instead of without any location at all.
|
@swift-ci Please test |
harlanhaskins
approved these changes
Dec 6, 2018
|
Build failed |
jrose-apple
force-pushed
the
a-module-by-any-other-name
branch
from
c805993 to
8133161
Compare
|
@swift-ci Please test Linux |
|
@swift-ci Please smoke test macOS |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the name for the cached module, so that we don't end up with a zillion "x86_64-XXXXXXXX.swiftmodule" files in the cache when we're working with architecture-specific swiftmodules.
Diagnose if the expected name is different from the name specified in the swiftinterface.
Emit all diagnostics at the location of the import, instead of without any location at all.
Also sneak in a separate commit to allow
@objceven withoutimport Foundationin swiftinterfaces.