[ParseableInterface] Fix printing for properties with initializers and observers #21269
Conversation
|
@swift-ci please test |
harlanhaskins
force-pushed
the
what-does-pc-load-letter-even-mean
branch
from
e943288 to
b828ea3
Compare
lib/AST/ASTPrinter.cpp
Outdated
There was a problem hiding this comment.
Hm, this if should probably be guarding the next section…
There was a problem hiding this comment.
Yeah, this was left over from the original implementation. I'll just go ahead and change it. Should we even have the option to turn it off, now that var initializers are part of the public interface anyway?
There was a problem hiding this comment.
I…guess not? Although I suppose we could have an option that chooses between "all of them" and "only the ones that are public".
|
Build failed |
lib/AST/ASTPrinter.cpp
Outdated
There was a problem hiding this comment.
Can you add a comment stating why this whole mess is necessary?
lib/AST/ASTPrinter.cpp
Outdated
There was a problem hiding this comment.
This seems like it'll print the same entry twice when there are two VarDecls in the same entry.
There was a problem hiding this comment.
It might just be more profitable and cleaner to figure out when we print a single VarDecl without going through the pattern binding. That's what's really happening here.
There was a problem hiding this comment.
That _hasInitialValue is suspicious. We shouldn't present that knowledge in a resilient struct. (And arguably not in a fragile struct either, but let's not worry about that right now.)
There was a problem hiding this comment.
That makes sense -- that's the existing behavior, so I'll fix that in a follow-up patch.
|
Build failed |
harlanhaskins
force-pushed
the
what-does-pc-load-letter-even-mean
branch
from
b828ea3 to
2f13f1b
Compare
|
@jrose-apple This should be much simpler. |
Don’t print var initializers if `Options.VarInitializers` is false.
harlanhaskins
force-pushed
the
what-does-pc-load-letter-even-mean
branch
from
2f13f1b to
05f7cdb
Compare
… pattern bindings
harlanhaskins
force-pushed
the
what-does-pc-load-letter-even-mean
branch
from
05f7cdb to
b3e6f1a
Compare
|
Your test case got lost. |
harlanhaskins
force-pushed
the
what-does-pc-load-letter-even-mean
branch
from
b3e6f1a to
0b62614
Compare
|
@jrose-apple Thanks! |
|
@swift-ci please test and merge |
…h storage Instead of only printing through the pattern binding, and potentially missing stored properties with property observers, defer to the pattern binding for all stored properties, and print accessors if applicable while printing pattern bindings.
harlanhaskins
force-pushed
the
what-does-pc-load-letter-even-mean
branch
from
0b62614 to
7fe74b2
Compare
|
@swift-ci please test and merge |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
Instead of only printing through the pattern binding, and potentially missing stored properties with property observers, defer to the pattern binding for all stored properties, and print accessors if applicable while printing pattern bindings.
Fallout from rdar://43815861