SILGen: Soften assertions it is okay for an base value of an boxed ex… #21296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…istentials not to be an address rdar://46343977
|
@swift-ci Please test and merge |
rjmccall
approved these changes
Dec 13, 2018
| base.getType().getPreferredExistentialRepresentation(SGF.SGM.M) == | ||
| ExistentialRepresentation::Boxed) && | ||
| "base value of open-existential component was not an address or a " | ||
| "boxed existential?"); |
There was a problem hiding this comment.
It's weird that boxed existentials end up in OpenOpaqueExistentialComponent, but I see that there's code there explicitly to handle them, so I guess it's as-intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…istentials not to be an address
rdar://46343977