Sema: Remove bogus call to requestNominalLayout() #21705
Conversation
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
|
||
|
|
||
| class C<T> { | ||
| dynamic func broken() { } // expected-error{{'dynamic'}} | ||
| func broken() { } |
There was a problem hiding this comment.
@DougGregor do you have a test case that demonstrates an actual crash or miscompile? Here we no longer finalize broken() but I'm not convinced that's a problem.
There was a problem hiding this comment.
Hmm. I don't have a test case that demonstrates the actual crash; this test case was heavily reduced.
The logic behind my addition of this requestNominalLayout call (in 76eb767) is that when you call a function, you produce a value of that type. IRGen is going to need to be able to lay out that type, so the type checker needs to be able to precompute it.
There was a problem hiding this comment.
getAnyNominal() is not sufficient, though. You might return a tuple containing nominals, or optionals, etc, and extract fields from there without making further calls.
There was a problem hiding this comment.
I agree that it's not sufficient.
No description provided.