[SILGen] Use the signature of the real UIApplicationMain #2180
Conversation
|
@swift-ci Please test @jckarter or @slavapestov, mind reviewing? |
|
@swift-ci Please test |
| /*isForeign*/true}; | ||
| auto UIApplicationMainFn = SGM.M.getOrCreateFunction(mainClass, mainRef, | ||
| NotForDefinition); | ||
| assert(UIApplicationMainFn && "failed to lower UIApplicationMain to SIL"); |
There was a problem hiding this comment.
I don't think getOrCreateFunction() can return nullptr, and if it did you would crash on the next line anyway, so I suggest removing this assert.
There was a problem hiding this comment.
Thanks, removed.
|
I don't see anything obviously wrong here, but I don't have enough knowledge of the underlying issue. |
...instead of trying to guess it ourselves. My previous attempt at this (part of the optional pointers work, bc83940) made a critical mistake because our only test case /also/ referenced UIApplicationMain directly. I've made the test case test several more situations, and also added what /would/ be an execution test if our simulator testing handled UI-based tests. rdar://problem/25712303
jrose-apple
force-pushed
the
UIApplicationMain
branch
from
d2a0765 to
1edaafa
Compare
|
Looks reasonable. The |
|
I couldn't get it to reliably be force-inlined, although this morning I realized that was probably because the "inline me" flag needs to be set at the use site, not just on the function. It also would have required an extra NSString-to-String-to-NSString conversion anyway given how UIApplicationMain normally comes in, something we'd peephole but still making extra work for the optimizer. Crossed fingers re: future SDK changes. |
...instead of trying to guess it ourselves.
My previous attempt at this (part of the optional pointers work, bc83940) made a critical mistake because our only test case also referenced UIApplicationMain directly. I've made the test case test several more situations, and also added what would be an execution test if our simulator testing handled UI-based tests.
rdar://problem/25712303
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.