Some TF stdlib fixes #22112
Merged
Some TF stdlib fixes #22112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test tensorflow |
The VJP registered for the squeezingAxes variant of each of those methods is in fact the correct VJP for the alongAxes variant; the VJP for the squeezingAxes variant requires inserting an additional dimension, which is left for future implementation.
jekbradbury
force-pushed
the
resnet-fixes
branch
from
7d9522f to
57e295b
Compare
|
@swift-ci Please test tensorflow |
|
@swift-ci Please test tensorflow |
…n't leak owned values.
|
@swift-ci please test tensorflow |
|
@swift-ci please test tensorflow Linux |
|
@swift-ci please test tensorflow |
|
Locally tested. Merging to unblock deadline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix VJPs for sum and mean, and add Tensor.variance.
The VJP registered for the squeezingAxes variant of sum and mean
methods is in fact the correct VJP for the alongAxes variant; the VJP
for the squeezingAxes variant requires inserting an additional
dimension, which is left for future implementation.