Fix getAccessedStorageFromAddress to handle AddressToPointer. #22195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pattern is normally folded away: %ga = global_addr @Gvar : $*Int64 %ptr = address_to_pointer %ga : $*Int64 to $Builtin.RawPointer %adr = pointer_to_address %ptr : $Builtin.RawPointer to [strict] $*Int64 %access = begin_access [read] [dynamic] [no_nested_conflict] %adr : $*Int64 However, now that we handle address type phi arguments in the SIL verifier, we could see this pattern. [In the long term, when address-type phis are universally prohibited, all of this stuff becomes irrelevant.] Fixes <rdar://47555992> [Source Compat] AudioKit: SIL verification failed: Unknown formal access pattern: storage.
|
@swift-ci test. |
|
@swift-ci test source compatibility. |
|
Reviewed by @eeckstein . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pattern is normally folded away:
%ga = global_addr @Gvar : $*Int64$Builtin.RawPointer to [strict] $ *Int64
%ptr = address_to_pointer %ga : $*Int64 to $Builtin.RawPointer
%adr = pointer_to_address %ptr :
%access = begin_access [read] [dynamic] [no_nested_conflict] %adr : $*Int64
However, now that we handle address-type phi arguments in the SIL
verifier, we could see this pattern. [In the long term, when
address-type phis are universally prohibited, all of this stuff
becomes irrelevant.]
Fixes rdar://47555992 [Source Compat] AudioKit: SIL verification
failed: Unknown formal access pattern: storage.