Skip to content

Conversation

compnerd
Copy link
Member

Use w+b mode for the files to avoid EOL style conversions on Windows.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

Use `w+b` mode for the files to avoid EOL style conversions on Windows.
@compnerd
Copy link
Member Author

CC: @ahoppen

@compnerd
Copy link
Member Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - ff7b2fb

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ahoppen
Copy link
Member

ahoppen commented Jan 29, 2019

macOS test failure seems to be unrelated, let's try again.

@swift-ci Please test macOS platform

@compnerd compnerd merged commit d072ceb into swiftlang:master Jan 29, 2019
@compnerd compnerd deleted the eol branch January 29, 2019 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants