Skip to content

Small ASTMangler tweak to make it work from lldb #22241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2019
Merged

Small ASTMangler tweak to make it work from lldb #22241

merged 1 commit into from
Jan 30, 2019

Conversation

slavapestov
Copy link
Contributor

Follow-up to #22237.

@slavapestov slavapestov mentioned this pull request Jan 30, 2019
Merged
@slavapestov
ASTDemangler: Make it work from lldb
fee5bc4 
For some reason, findDeclContext() finds the special ClangImporter
module from inside lldb, and then we were skipping the logic in
findForeignTypeDecl(). So check for the foreign type case first.
@slavapestov slavapestov force-pushed the type-reconstruction-lldb-fix branch from 401a5a8 to fee5bc4 Compare January 30, 2019 17:54
@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@slavapestov slavapestov changed the title Type reconstruction rework, part 4 [WIP] Small ASTMangler tweak to make it work from lldb Jan 30, 2019
@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test macOS

@slavapestov slavapestov merged commit 1271d89 into swiftlang:master Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slavapestov @DougGregor