[stdlib] Avoid storing NULL into a Builtin.RawPointer. #2236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gribozavr, mind sanity-checking this? @swift-ci Please test |
|
@jrose-apple LGTM, thank you! |
Found by Dmitri.
jrose-apple
force-pushed
the
StaticString
branch
from
4eddfe6 to
b5f38ed
Compare
|
@swift-ci Please test |
gparker42
pushed a commit
that referenced
this pull request
Apr 20, 2016
This broke test sil-opt/emit-sib.swift with compiler asserts enabled. https://ci.swift.org/job/oss-swift_tools-RA_stdlib-DA_test-simulator/1022/ This reverts commit 6b8cd5c.
|
Reverted in a14a836. It broke a compiler assertion in test sil-opt/emit-sib.swift. |
|
How exciting. Thanks, Greg. |
gottesmm
pushed a commit
to gottesmm/swift
that referenced
this pull request
Apr 20, 2016
…ftlang#2236)" Re-apply 6b8cd5c, reverted in a14a836, now that the prespecialization assertions have been relaxed.
|
Reapplied in acbcf04, with a fix for the failure in the parent commit. Hoping it sticks. |
MaxDesiatov
pushed a commit
that referenced
this pull request
Apr 19, 2021
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.