Skip to content

[5.0] Revert count(where:) #22382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2019
Merged

[5.0] Revert count(where:) #22382

merged 1 commit into from
Feb 6, 2019
+4 −188

Conversation

moiseev
Copy link
Contributor

@moiseev moiseev commented Feb 5, 2019

  • Explanation: Introduction of this API made certain expressions much
    harder to typecheck. Reverting it gets that compilation performance back.
  • Scope of Issue: This is fairly new API that was introduced earlier in
    this release cycle.
  • Risk: Minimal
  • Reviewed By: Ben Cohen
  • Testing: Automated test suite
  • Directions for QA: N/A
  • Radar: rdar://problem/47549309

@airspeedswift @moiseev
Revert count(where:)
916eb2d 
(cherry picked from commit 779ea19)
@moiseev moiseev requested a review from a team as a code owner February 5, 2019 19:16
@moiseev
Copy link
Contributor Author

moiseev commented Feb 5, 2019

@swift-ci Please test

@moiseev
Copy link
Contributor Author

moiseev commented Feb 5, 2019

@swift-ci Please nominate

@airspeedswift airspeedswift merged commit 00dbfa1 into swiftlang:swift-5.0-branch Feb 6, 2019
@moiseev moiseev deleted the count-where-revert-5 branch February 12, 2019 21:29
@benrimmington benrimmington mentioned this pull request Jan 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airspeedswift airspeedswift airspeedswift approved these changes

Assignees

@airspeedswift airspeedswift

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moiseev @airspeedswift