Skip to content

Debug Info: Encode Archetype names in DWARF #22752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2019

Conversation

adrian-prantl
Copy link
Contributor

Currently LLDB calls into ide::getDeclFromMangledSymbolName() to get
to this information and we would like to get rid of this call.

rdar://problem/47798056

@adrian-prantl
Copy link
Contributor Author

@swift-ci test

@slavapestov
Copy link
Contributor

Sorry for the inconvenience but do you mind rebasing this on top of #22252 ? We really only need names for top-level generic parameters; dependent member type names are part of the mangling and don't need to be recorded here.

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 587ada2aa631477ef805b8a9d976db3e24da8ed9

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 587ada2aa631477ef805b8a9d976db3e24da8ed9

Currently LLDB calls into ide::getDeclFromMangledSymbolName() to get
to this information and we would like to get rid of this call.

rdar://problem/47798056
@adrian-prantl
Copy link
Contributor Author

test with apple/swift-lldb#1318
@swift-ci test

@adrian-prantl
Copy link
Contributor Author

@slavapestov I think rebasing this on #22252 or vice versa shouldn't be hard at all so the order in which we land these probably doesn't matter too much.

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 3b7353a

@adrian-prantl
Copy link
Contributor Author

test with apple/swift-lldb#1318
@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 3b7353a

@adrian-prantl
Copy link
Contributor Author

Linux test failed because a Foundation test failed, which is likely unrelated to this patch.

@adrian-prantl
Copy link
Contributor Author

test with apple/swift-lldb#1318
@swift-ci test

@adrian-prantl adrian-prantl merged commit 5b80101 into swiftlang:master Feb 22, 2019
@adrian-prantl adrian-prantl changed the title [dontmerge] Debug Info: Encode Archetype names in DWARF Debug Info: Encode Archetype names in DWARF Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants