[Sema] SR-9851 - Add parens when needed for nil coalescing fixits

[xcadaverx]

https://bugs.swift.org/browse/SR-9851

This is a fix for parens not being added on certain nil coalescing fix-its due to a root expression not being passed down to exprNeedsParensOutsideFollowingOperator.

Resolves SR-9851.

[xedin]

Thanks, @xcadaverx! I will take a look later tonight or tomorrow!

[beccadax]

@swift-ci please test

[swift-ci]

Build failed
Swift Test OS X Platform
Git Sha - 1d88c47

[xedin]

Looks like mac failures are unrelated to these changes:

01:58:27 2019-02-21 23:58:24.173 xcodebuild[26422:3697164]  DVTDownloadable: Failed to get authorization with error Error Domain=DVTDownloadableErrors Code=3 "The authorization was denied since no user interaction was possible." UserInfo={AuthorizationErrorCode=-60007, NSLocalizedDescription=The authorization was denied since no user interaction was possible.}

[xedin]

@swift-ci please smoke test macOS platform

[xedin]

LGTM, Thank you!

[xedin]

@swift-ci please test macOS platform

[swift-ci]

Build failed
Swift Test OS X Platform
Git Sha - 1d88c47

[xcadaverx]

Still failing because of this:

06:29:09 2019-02-22 04:29:07.688 xcodebuild[93083:4290577]  DVTDownloadable: Failed to get authorization with error Error Domain=DVTDownloadableErrors Code=3 "The authorization was denied since no user interaction was possible." UserInfo={AuthorizationErrorCode=-60007, NSLocalizedDescription=The authorization was denied since no user interaction was possible.}
06:29:09 xcodebuild: error: The authorization was denied since no user interaction was possible.

Did I break that somehow? :)

[aschwaighofer]

@shahmishal This is the same error I am seeing on my PR #22712
When running a full test.

Something seems to be wrong on the bot?

[xedin]

I think it's okay to merge, I was just hoping that it's only reproducible on one machine.

[xedin]

@xcadaverx Thanks again and please don't forget to resolve JIRA!