Skip to content

Update WindowsBuild.md #22812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2019
Merged

Update WindowsBuild.md #22812

merged 1 commit into from
Feb 22, 2019

Conversation

compnerd
Copy link
Member

Now that the flags have been fixed for the runtime build, we no longer need to ignore the overly verbose warnings. We now emit warnings which we should really cleanup.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

Now that the flags have been fixed for the runtime build, we no longer need to ignore the overly verbose warnings.  We now emit warnings which we should really cleanup.
@compnerd
Copy link
Member Author

CC: @gwynne

@compnerd
Copy link
Member Author

@swift-ci please smoke test and merge

Copy link
Contributor

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Win! 👍

@swift-ci swift-ci merged commit aff0709 into master Feb 22, 2019
@compnerd compnerd deleted the warnings-have-reined branch February 22, 2019 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants