Skip to content

[test] Un-XFAIL a test for watchOS #22813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2019

Conversation

jrose-apple
Copy link
Contributor

Whatever bug is happening in SR-9847, the watchOS overlays aren't hitting it.

rdar://problem/48280638

Whatever bug is happening in https://bugs.swift.org/browse/SR-9847,
the watchOS overlays aren't hitting it.

rdar://problem/48280638
@jrose-apple
Copy link
Contributor Author

@swift-ci Please smoke test and merge

@shahmishal
Copy link
Member

@millenomi Should we disable this test for now?

11:24:29 Test Case 'TestURLSession.test_dataTaskWithHttpInputStream' started at 2019-02-22 19:24:11.226
11:24:29 /home/buildnode/jenkins/workspace/swift-PR-Linux-smoke-test/branch-master/swift-corelibs-foundation/TestFoundation/TestURLSession.swift:170: error: TestURLSession.test_dataTaskWithHttpInputStream : XCTAssertEqual failed: ("1316 bytes") is not equal to ("1323 bytes") - Response Data and Data is not equal
11:24:29 Test Case 'TestURLSession.test_dataTaskWithHttpInputStream' failed (0.003 seconds)

@shahmishal
Copy link
Member

@swift-ci smoke test Linux

@millenomi
Copy link
Contributor

cc @ianpartridge for the test

@jrose-apple
Copy link
Contributor Author

@swift-ci Please smoke test Linux

@benrimmington
Copy link
Contributor

@jrose-apple Does this PR need a full validation test (to include the watchOS simulator)?

@jrose-apple
Copy link
Contributor Author

The test in question is a "long test" anyway, so it won't run in PR testing mode to begin with. We…should probably have a way to ask for that.

@jrose-apple jrose-apple merged commit d17602a into swiftlang:master Feb 25, 2019
@jrose-apple jrose-apple deleted the watch-me-now branch February 25, 2019 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants