[parse/sema] Give all case bodies their own var decls without using t… #23499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
|
In a forthcoming commit I am going to change emission to use these. At least with this commit we know that the basic functionality around the var decl linked list is not broken by introducing these case body var decls into that list. |
…hose var decls for anything. This is a step in the direction of fixing the fallthrough bug. Specifically, in this commit I give case stmts a set of var decls for the bodies of the case statement. I have not wired them up to anything except the var decl list/typechecking. rdar://47467128
gottesmm
force-pushed
the
pr-7c99cd81f730147d0e6b637f864da32d1511a450
branch
from
ab4c6d8 to
b50d878
Compare
|
@swift-ci smoke test |
|
@nathawes I think this test is going to pass. Can I get that review? |
|
@nathawes it did pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hose var decls for anything.
This is a step in the direction of fixing the fallthrough bug. Specifically, in
this commit I give case stmts a set of var decls for the bodies of the case
statement. I have not wired them up to anything except the var decl
list/typechecking.
rdar://47467128