AST: switch to std::sort from llvm::array_pod_sort
#23620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swap the `array_pod_sort` to `sort`. `array_pod_sort` is meant to be used with POD types only. Switching to `std:sort` should be slightly faster, and more importantly, allows the emission of the warnings on Windows to be sorted identically to Linux and macOS.
|
CC: @DougGregor |
|
@swift-ci please test |
|
Are the constraint types not POD in practice? But if the sort isn't stable, that may be enough reason to do this anyway. |
|
I believe that std::sort isn't stable, but there's a std::stable_sort. I think you need the latter if you want stability. |
|
Oops, right, and we've definitely run into that before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swap the
array_pod_sorttosort.array_pod_sortis meant to beused with POD types only. Switching to
std:sortshould be slightlyfaster, and more importantly, allows the emission of the warnings on
Windows to be sorted identically to Linux and macOS.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.