[benchmarks] Change the build_script_helper to use subdirectories for each build and install final binaries in a toplevel ./bin build directory. #23943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… each build and install final binaries in a toplevel ./bin build directory. This will let me: 1. Add -Osize support easily. 2. Put all of the binaries in the same directory so that Benchmark_Driver can work with them via the -tools argument.
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will let me:
work with them via the -tools argument.
NOTE: I included in this PR a small commit that moves this python script from ./benchmark/utils => ./benchmark/scripts. That is really where it should be. It was an oversight on my part.