Skip to content

add Set test #24426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2019
Merged

add Set test #24426

merged 1 commit into from
May 2, 2019

Conversation

Gumichocopengin8
Copy link
Contributor

  • add filter test in set validation test
  • change var to let

@Gumichocopengin8 Gumichocopengin8 changed the title Set test add Set test May 2, 2019
@Gumichocopengin8
Copy link
Contributor Author

Gumichocopengin8 commented May 2, 2019 •
edited
Loading

CC: @lorentey @atrick, @airspeedswift
Could you please review this?
Thank you.

atrick
atrick approved these changes May 2, 2019
View reviewed changes
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@atrick
Copy link
Contributor

atrick commented May 2, 2019

@swift-ci test.

@Gumichocopengin8
Copy link
Contributor Author

@atrick Thanks!

@atrick
Copy link
Contributor

atrick commented May 2, 2019

@lorentey do you think it's ok to merge this now?

lorentey
lorentey approved these changes May 2, 2019
View reviewed changes
Copy link
Member

@lorentey lorentey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thank you for adding these.

@lorentey lorentey merged commit ed32972 into swiftlang:master May 2, 2019
@Gumichocopengin8 Gumichocopengin8 deleted the set-test branch September 22, 2020 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorentey lorentey lorentey approved these changes

@atrick atrick atrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gumichocopengin8 @atrick @lorentey