Skip to content

IRGen: Don't emit opaque type descriptors twice #24517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2019
Merged

IRGen: Don't emit opaque type descriptors twice #24517

merged 2 commits into from
May 7, 2019

Conversation

aschwaighofer
Copy link
Contributor

rdar://50500620

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test

@aschwaighofer aschwaighofer requested a review from jckarter May 6, 2019 17:03
@swift-ci
Copy link
Contributor

swift-ci commented May 6, 2019

Build failed
Swift Test OS X Platform
Git Sha - fc8ff70

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented May 6, 2019

Build failed
Swift Test Linux Platform
Git Sha - fc8ff70

@swift-ci
Copy link
Contributor

swift-ci commented May 6, 2019

Build failed
Swift Test OS X Platform
Git Sha - fc8ff70

@slavapestov
Copy link
Contributor

I guess a test case would require the lazy opaque type to be referenced before its definition point? So probably again lifting it to a typealias via associated type inference might be the easiest way

@aschwaighofer
Copy link
Contributor Author

I will follow-up with a test case later.

@aschwaighofer aschwaighofer merged commit 510764a into swiftlang:master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jckarter jckarter Awaiting requested review from jckarter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aschwaighofer @swift-ci @slavapestov