[api-digester] Serialize protocol USRs in conformances #24586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK conformance nodes include only protocol `name` and `printedName`, both are demangled. USR field of the protocol type is added, to be able to uniquely identify conformances.
nkcsgexi
approved these changes
May 13, 2019
|
Fixed 👍 |
|
@swift-ci please smoke test |
|
@swift-ci Please smoke test OS X platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently SDK conformance nodes include protocol
nameandprintedNamekeys, where both are equal, demangled names. Seems like this is sufficient for changes analysis, but its not possible to uniquely identify the protocols.For my use case including USR would be very useful, as then protocols can be identified across module boundaries. Currently I can't be certain about this even with some intermediate analysis, as there could be a collision in protocol names between modules.
The information is already there, it only has to be serialised.
Tests for stdlib are passing on my local machine without any changes.
I tried to update them as well, but there were other changes as well, so I guess the file stdlib inputs are not totally up to date?
@nkcsgexi do you think this is relevant for upstreaming?