Skip to content

[Test][Trivial] Fixing let var warnings on CheckCollectionInstance.swift #24726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2019
Merged

[Test][Trivial] Fixing let var warnings on CheckCollectionInstance.swift #24726

merged 1 commit into from
May 14, 2019

Conversation

LucianoPAlmeida
Copy link
Contributor

Note this
Screen Shot 2019-05-12 at 18 25 23

while running validation-tests locally.
So it's just a trivial patch fixing these warnings :))

milseman
milseman approved these changes May 13, 2019
View reviewed changes
Copy link
Member

@milseman milseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@milseman
Copy link
Member

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 94a9a9b

@milseman
Copy link
Member

@swift-ci please smoke test linux platform

@milseman milseman merged commit 331e192 into swiftlang:master May 14, 2019
@LucianoPAlmeida LucianoPAlmeida deleted the fix-let-var-warnings branch July 13, 2019 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milseman milseman milseman approved these changes

@airspeedswift airspeedswift Awaiting requested review from airspeedswift

@lorentey lorentey Awaiting requested review from lorentey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LucianoPAlmeida @milseman @swift-ci