Test foreign strings on invalid content more thoroughly #24874
Conversation
| let kCFStringEncodingASCII: UInt32 = 0x0600 | ||
|
|
||
| private func testForeignContiguous(slowString: NSSlowString, string: String) { |
There was a problem hiding this comment.
This is just the bit below pulled out so I can reuse it for the second set of data
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
"LLDB :: SwiftREPL/BreakpointSimple.test" is absolutely not caused by adding unrelated tests |
|
@swift-ci please test osx platform |
|
@swift-ci please test |
|
Build failed |
|
This time Interpreter/switch_resilience.swift :/ still not caused by this |
|
@swift-ci please test |
|
Build failed |
|
Test run hung >.< |
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test linux platform |
|
|
||
| // They become fast when mutated | ||
| slowString.makeNative() | ||
| expectTrue(slowString.isFastUTF8) |
There was a problem hiding this comment.
Oh right, this test predates contiguous strings proposal. You can go this route, or update the test to use isContiguousUTF8, makeContiguousUTF8(), and withUTF8().
There was a problem hiding this comment.
Noted. I'm probably going to leave it as unchanged as possible for now.
No description provided.