[TF] Helpers to facilitate the move to swift-apis. #25101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test tensorflow |
rxwei
approved these changes
May 28, 2019
Sounds good. They are internal in TensorFlowGraph/swift-apis#109 and my plan is to keep that PR updated to our "desired state" and then after merging all component PRs, merge that one which will revert minor changes such as this one. |
|
Did it compile for you locally? |
|
It's still compiling and didn't get to that point. I'll fix this now. One issue I'm having is that I made these changes in a complete new clone of the repo so I need to wait for a clean compile to finish before I use incremental compilation. |
|
I fixed this failure and pushed but still waiting for it compile locally. It'd probably be faster to rerun the CI tests. |
|
@swift-ci please test tensorflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rxwei This should allow testing tensorflow/swift-apis#137.