Skip to content

Streamline fixed-size buffers in the standard library #25131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2019
Merged

Streamline fixed-size buffers in the standard library #25131

merged 2 commits into from
May 30, 2019

Conversation

stephentyrone
Copy link
Contributor

@stephentyrone stephentyrone commented May 29, 2019 •
edited
Loading

  • It turns out that 16 is the only size that the stdlib actually uses with _FixedArray, so the .gyb isn't eliminating any boilerplate anyway; make it a normal Swift file.
  • _SmallBuffer simply isn't used at all, so get rid of it.

@stephentyrone
De-GYB FixedArray.swift
27ccf1b 
It turns out that 16 is the only size that the stdlib actually uses, so the .gyb isn't eliminating any boilerplate anyway.
@stephentyrone stephentyrone requested a review from lorentey May 29, 2019 23:21
@stephentyrone
Copy link
Contributor Author

@swift-ci smoke test

@stephentyrone
It turns out that _SmallBuffer<T> simply isn't used at all
9573841 
... so that's another vestigial static-buffer we can eliminate.
@stephentyrone stephentyrone changed the title De-GYB FixedArray.swift Streamline fixed-size buffers in the standard library May 29, 2019
@stephentyrone
Copy link
Contributor Author

@swift-ci test and merge

@gottesmm
Copy link
Contributor

Woot!

@gottesmm
Copy link
Contributor

@swift-ci test and merge

1 similar comment
@gottesmm
Copy link
Contributor

@swift-ci test and merge

@swift-ci swift-ci merged commit 9571d46 into swiftlang:master May 30, 2019
@stephentyrone stephentyrone deleted the de-gyb-fixedarray branch May 30, 2019 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorentey lorentey lorentey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephentyrone @gottesmm @lorentey @swift-ci