Remove a workaround in the debug info handling of zero-sized types. #25435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes potential LLVM verifier errors in exploded variables with undefined elments, because a few lines below the size of fragments is derived from the size of the LLVM SSA value and the constant used in the deleted workaround is always an i64. rdar://problem/51343998
|
test with apple/swift-lldb#1683 |
|
test with apple/swift-lldb#1683 |
|
Build failed |
dcci
approved these changes
Jun 13, 2019
|
test with apple/swift-lldb#1683 |
|
Build failed |
|
Build failed |
|
test with apple/swift-lldb#1683 |
|
Linux test failed with unrelated swiftpm build failure. Keep trying... |
|
test with apple/swift-lldb#1683 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes potential LLVM verifier errors in exploded variables with undefined
elments, because a few lines below the size of fragments is derived from the
size of the LLVM SSA value and the constant used in the deleted workaround is
always an i64.
rdar://problem/51343998