Skip to content

[CSDiag] Always find and set correct declaration context for sub-expr… #25443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2019
Merged

[CSDiag] Always find and set correct declaration context for sub-expr… #25443

merged 2 commits into from
Jun 18, 2019

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Jun 13, 2019

…ession type-check

Replace dedicated method with typeCheckChildIndependently always
setting the closest possible declaration context for type-check call.
This fixes a problem where sub-expression comes from multiple levels
or nested closures but CSDiag didn't re-typecheck parent closure.

Resolves: rdar://problem/50869732

@xedin
Copy link
Contributor Author

xedin commented Jun 13, 2019

@swift-ci please build toolchain

@xedin
Copy link
Contributor Author

xedin commented Jun 13, 2019

I'm going to reduce example from SwiftUI and add it to the suite.

@swift-ci
Copy link
Contributor

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - 65bc983ec9dabc1f0686a389344ab29778c50a33

Install command
tar zxf swift-PR-25443-242-ubuntu16.04.tar.gz
More info

@xedin
Copy link
Contributor Author

xedin commented Jun 14, 2019

@swift-ci please build toolchain macOS

@swift-ci
Copy link
Contributor

macOS Toolchain
Download Toolchain
Git Sha - 65bc983ec9dabc1f0686a389344ab29778c50a33

Install command
tar -zxf swift-PR-25443-316-osx.tar.gz --directory ~/

@xedin
[CSDiag] Always find and set correct declaration context for sub-expr…
a5df786 
…ession type-check

Replace dedicated method with `typeCheckChildIndependently` always
setting the closest possible declaration context for type-check call.
This fixes a problem where sub-expression comes from multiple levels
or nested closures but CSDiag didn't re-typecheck parent closure.

Resolves: rdar://problem/50869732
@xedin
Copy link
Contributor Author

xedin commented Jun 17, 2019

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Jun 17, 2019

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 65bc983ec9dabc1f0686a389344ab29778c50a33

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 65bc983ec9dabc1f0686a389344ab29778c50a33

@xedin
Copy link
Contributor Author

xedin commented Jun 18, 2019

@swift-ci please test Linux platform

@xedin
Copy link
Contributor Author

xedin commented Jun 18, 2019

@swift-ci please test macOS platform

@xedin xedin merged commit ef293a5 into swiftlang:master Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xedin @swift-ci @DougGregor