Skip to content

[stdlib/cygwin] Removed the workaround of print() (SR-612) #2575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2016

Conversation

tinysun212
Copy link
Contributor

What's in this pull request?

Resolved bug number: (SR-612)


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
OS X platform @swift-ci Please test OS X platform
Linux platform @swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

Currently, in Cygwin, the print() function works well without any workaround.
I presume this bug is fixed by side effect of some other commit, but couldn't find out exactly what.

@gribozavr
Copy link
Contributor

@tinysun212 Please remove the variable declaration as well. As written, the code actually enables the workaround for all platforms.

Currently, in Cygwin, the print() function works well without any workaround.
I presume this bug is fixed by side effect of some other commit, but couldn't find out exactly what.
@tinysun212
Copy link
Contributor Author

Fixed a mistake.

@gribozavr
Copy link
Contributor

@swift-ci Please test and merge

1 similar comment
@gribozavr
Copy link
Contributor

@swift-ci Please test and merge

@gribozavr
Copy link
Contributor

CI failure is unrelated.

@gribozavr gribozavr merged commit 67004c8 into swiftlang:master May 19, 2016
@tinysun212 tinysun212 deleted the pr-fix-sr-612 branch October 21, 2018 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants