DWARFImporter: Allow filtering type lookups by containing module. #26707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test with apple/swift-lldb#1899 |
|
LLDB might know about submodules, but Swift doesn't; it considers them to be the same as the top-level module for filtering purposes. |
jrose-apple
reviewed
Aug 19, 2019
|
test with apple/swift-lldb#1899 |
|
I made a note (rdar://problem/54471165) to extend LLDB to allow searching for types in any submodule of a give top-level module. |
|
Looks like I forgot to amend my commit before pushing. |
|
test with apple/swift-lldb#1899 |
1 similar comment
|
test with apple/swift-lldb#1899 |
jrose-apple
approved these changes
Aug 20, 2019
|
test with apple/swift-lldb#1899 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bit of a problem with this in the current form. LLDB knows about submodules and would really like to have a fully qualified module::submodule::type decl context for the lookup. I may need to add a variant of LLDB's FindTypes that returns each type with its declContext so I can filter the results after the search instead.