[CMake] Correct dependencies for clang headers components #26915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
compnerd
reviewed
Aug 28, 2019
bulbazord
force-pushed
the
depend-on-clang-headers
branch
from
92d41dd to
b2febd8
Compare
|
@swift-ci please smoke test |
compnerd
reviewed
Sep 2, 2019
When building swift as a part of LLVM (as opposed to standalone) the components related to swift headers should explicitly depend on the clang target to produce those. On LLVM 9 and up, that would be `clang-resource-headers` and on lower versions it would be `clang-headers`. It is important that we check for `clang-resource-headers` first because `clang-headers` refers to something different in LLVM 9 and up.
bulbazord
force-pushed
the
depend-on-clang-headers
branch
from
b2febd8 to
d57c841
Compare
|
@swift-ci please smoke test |
compnerd
approved these changes
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building swift as a part of LLVM (as opposed to standalone) the components
related to swift headers should explicitly depend on the clang target to produce
those. On LLVM 9 and up, that would be
clang-resource-headersand on lowerversions it would be
clang-headers. It is important that we check forclang-resource-headersfirst becauseclang-headersrefers to somethingdifferent in LLVM 9 and up.
cc @compnerd @gottesmm @Rostepher